On 18/04/2018 00:40, Laszlo Ersek wrote: > +# > +# Lists firmware types commonly used with QEMU virtual machines. > +# > +# @bios: The firmware was built from the SeaBIOS project. > +# > +# @slof: The firmware was built from the Slimline Open Firmware project. > +# > +# @uboot: The firmware was built from the U-Boot project. > +# > +# @uefi: The firmware was built from the edk2 (EFI Development Kit II) project. > +# > +# Since: 2.13 > +## > +{ 'enum' : 'FirmwareType', > + 'data' : [ 'bios', 'slof', 'uboot', 'uefi' ] } A very basic question (so not likely a suggestion for change). Why wouldn't these be features too? For example a UEFI with CSM could expose both uefi and bios, a u-boot with UEFI support could expose both uboot and uefi, etc. Perhaps there are two dimensions, the FirmwareType tells you how to configure it and the FirmwareFeature tells you the APIs it exposes to the guest? Paolo -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list