Re: [dbus PATCH 10/25] Implement BlockRebase method for Domain Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 17, 2018 at 07:26:15PM +0200, Pavel Hrdina wrote:
> On Tue, Apr 17, 2018 at 02:04:29PM +0200, Katerina Koukiou wrote:
> > Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx>
> > ---
> >  data/org.libvirt.Domain.xml |  8 ++++++++
> >  src/domain.c                | 29 +++++++++++++++++++++++++++++
> >  2 files changed, 37 insertions(+)
> > 
> > diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
> > index 46a6632..f5c7fb0 100644
> > --- a/data/org.libvirt.Domain.xml
> > +++ b/data/org.libvirt.Domain.xml
> > @@ -91,6 +91,14 @@
> >        <arg name="bandwidth" type="t" direction="in"/>
> >        <arg name="flags" type="u" direction="in"/>
> >      </method>
> > +    <method name="BlockRebase">
> > +      <annotation name="org.gtk.GDBus.DocString"
> > +        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainBlockRebase"/>

One more thing, we should document that empty string is same as
NULL, for example:

"Empty string can be used to pass a NULL as @base argument."

Pavel

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux