On 04/14/2018 05:25 AM, Rainer Müller wrote: > These changes were required to get VMware Fusion working at all. > I tested with VMware Fusion 10.1.1 on macOS 10.12 Sierra. > > I am not sure whether calling virCapabilitiesInitCaches() makes sense at > all on macOS. This function looks highly specific to Linux as it relies > on /sys/devices/system, so it should probably be wrapped with an > appropriate #ifdef. I do not feel proficient enough with the libvirt > internals to make this change, though. > > v1 was here: > https://www.redhat.com/archives/libvir-list/2018-April/msg00087.html > > diff to v1: > - Fix a possible segfault when vmrun is not found in PATH. > > Rainer Müller (2): > vmware: Fix initialization of VMware Fusion > vmware: Failures in cache info init are non-fatal > > src/vmware/vmware_conf.c | 7 ++++++- > src/vmware/vmware_driver.c | 11 ++++++++++- > 2 files changed, 16 insertions(+), 2 deletions(-) > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> (series) and pushed. Thanks, John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
