Re: [PATCH v3 2/5] src: Unify virObject member name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 17, 2018 at 06:01:03PM +0200, Michal Privoznik wrote:
> Whenever we declare a new object the first member of the struct
> has to be virObject (or any other member of that family). Now, up
> until now we did not care about the name of the struct member.
> But lets unify it so that we can do some checks at compile time
> later.
> 
> The unified name is 'parent'.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  src/datatypes.h               | 28 ++++++++++++++--------------
>  src/libvirt-admin.c           |  2 +-
>  src/libvirt-domain-snapshot.c |  2 +-
>  src/libvirt-domain.c          |  2 +-
>  src/libvirt-host.c            |  2 +-
>  src/libvirt-interface.c       |  2 +-
>  src/libvirt-network.c         |  2 +-
>  src/libvirt-nodedev.c         |  2 +-
>  src/libvirt-nwfilter.c        |  2 +-
>  src/libvirt-secret.c          |  2 +-
>  src/libvirt-storage.c         |  4 ++--
>  src/libvirt-stream.c          |  2 +-
>  src/qemu/qemu_capabilities.c  |  2 +-
>  src/rpc/virnetclientprogram.c |  2 +-
>  src/rpc/virnetserverprogram.c |  2 +-
>  src/rpc/virnetserverservice.c |  2 +-
>  src/util/virdnsmasq.c         |  2 +-
>  src/util/virfilecache.c       |  2 +-
>  tests/virfilecachetest.c      |  2 +-
>  19 files changed, 33 insertions(+), 33 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux