Hi Peter, I read the BZ comments and Cole's suggestion, but I didn't know about the requirements of the other hypervisors. Since slash is commonly used for paths. I will investigate it properly. -- Julio Cesar Faracco 2018-04-17 4:14 GMT-03:00 Peter Krempa <pkrempa@xxxxxxxxxx>: > > On Tue, Apr 17, 2018 at 00:27:27 -0300, Julio Faracco wrote: > > The 'domrename' command needs to check if the new domain name contains > > the slash character. This character is not accepted by libvirt XML > > definition because it is an invalid char (see Cole's commit b1fc6a7b7). > > This commit enhace the 'domrename' command adding this check. > > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1333232 > > > > Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx> > > --- > > src/internal.h | 9 +++++++++ > > src/libvirt-domain.c | 1 + > > 2 files changed, 10 insertions(+) > > Slash in VM name may be allowed for some hypervisors and when defining > the hypervisor defines this via VIR_DOMAIN_DEF_FEATURE_NAME_SLASH parser > feature flag. > > Currently it appears that virtualbox, phyp, vmx, and xenapi driver > support a slash so the fix below is wrong as it would forbid the slash > when renaming the VM for those drivers. > > This needs to be implemented in the qemu driver according to the BZ. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
