On Wed, Apr 11, 2018 at 11:20:43 -0400, John Ferlan wrote: > > > On 04/04/2018 04:13 AM, Peter Krempa wrote: > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > > --- > > tests/qemuxml2argvdata/disk-drive-write-cache.args | 45 ++++++++++++++++++++++ > > tests/qemuxml2argvdata/disk-drive-write-cache.xml | 45 ++++++++++++++++++++++ > > tests/qemuxml2argvtest.c | 1 + > > 3 files changed, 91 insertions(+) > > create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.args > > create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.xml > > > > This should be merged with patch 5 - there's also no xml2xml test I can squash this in to the previous patch, but I usually prefer having them separate when we are adding a lot of new lines. I don't think a XML2XML test is necessary here. This feature is not using any new XML configuration, but rather uses existing values to express the new configuration. > Also considering patch 2, all we're testing is x86_64 on 2.12 even > though we have the feature available on other arches for other versions. Well, given that prior to the ability to test it with real capabilities, we'd test it with a configuration which would not exist by listing the required capability bits in the surce file, the same would apply. > I don't believe we have any existing test that sets cache= to anything > other than 'none' (e.g. qemuDiskCacheV2 isn't really used or checked > currently). > > Why wouldn't any of the existing cache=none would change too... OK > other than the fact that you're only testing for 2.12 and beyond... As said above. That's originating from the fact that our previous testing sucked and did not really compare to anything real-life. If I'd were to add a DO_TEST case using the capability explicitly the tests would not change in the same way as they did not change here, so the version used for capabilities does not really matter in any way here. > > Perhaps it would have been interesting to see the results of this test > before the new capability and how it changes afterwards. I can shuffle them around if you want. But it then can't be merged with previous patch. Also until the feature is implemented, the test will not test what it is declaring to test.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
