Re: [PATCH] tests: Don't touch /dev/vhost-net in qemuxml2argvtest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 17, 2018 at 12:44:13PM +0200, Ján Tomko wrote:
On Tue, Apr 17, 2018 at 11:30:06AM +0200, Martin Kletzander wrote:
The code is trying to open /dev/vhost-net from the host machine and if the
current user has access to it, the command line will end up having two more
options for an interface (,vhost=on,vhostfd=X where X is next free file
descriptor).


Alternate proposal which mocks qemuInterfaceOpenVhostNet instead of
doing this per-path:
https://www.redhat.com/archives/libvir-list/2018-April/msg01433.html
(Even if we start testing the custom path to the vhost-net device,
we don't want to access the host)


Sure, I've no preference.

Jano

Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
---
tests/qemuxml2argvmock.c | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)



Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux