Re: [libvirt PATCH v2 40/44] Deprecate QEMU_CAPS_DUMP_GUEST_CORE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-04-09 at 17:27 +0200, Ján Tomko wrote:
> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
> index 670cd92b8f..78d9e10d0f 100644
> --- a/tests/qemuxml2argvtest.c
> +++ b/tests/qemuxml2argvtest.c
> @@ -732,16 +732,11 @@ mymain(void)
>      DO_TEST("minimal-msg-timestamp", QEMU_CAPS_MSG_TIMESTAMP);
>      DO_TEST("machine-aliases1", NONE);
>      DO_TEST("machine-aliases2", QEMU_CAPS_KVM);
> -    DO_TEST("machine-core-on",
> -            QEMU_CAPS_DUMP_GUEST_CORE);
> +    DO_TEST("machine-core-on", NONE);
>      driver.config->dumpGuestCore = true;
> -    DO_TEST("machine-core-off",
> -            QEMU_CAPS_DUMP_GUEST_CORE);
> +    DO_TEST("machine-core-off", NONE);
>      driver.config->dumpGuestCore = false;
> -    DO_TEST("machine-core-cfg-off",
> -            QEMU_CAPS_DUMP_GUEST_CORE);
> -    DO_TEST_FAILURE("machine-core-on", NONE);
> -    DO_TEST_FAILURE("machine-core-on", NONE);
> +    DO_TEST("machine-core-cfg-off", NONE);

Pretty much the entire test suite is providing coverage for this
last one now, so just drop it.

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux