On Tue, Apr 17, 2018 at 11:15:17AM +0200, Christian Ehrhardt wrote: > The recent fix to libvirt-guests.sh.in works for what it intended to fix > (variable scope) but failed to adapt the loop in check_guests_shutdown > correctly. Due to that it currently might detect all guests as "Failed to > determine state of guest" by bad var content or just assumes they are shut > down by picking up an empty variable. > > This commit fixes loop to use the passed value and the call in the loop > to actually use the variable assigned in the iterated. > > Fixes: 7e476356 "tools: fix variable scope in in check_guests_shutdown" > Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1764668 > > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@xxxxxxxxxxxxx> > --- > tools/libvirt-guests.sh.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Dariusz Gadomski <dariusz.gadomski@xxxxxxxxxxxxx> -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
