Daniel P. Berrange wrote: > * configure.in: Add check for mntent.h > * qemud/libvirtd_qemu.aug, qemud/test_libvirtd_qemu.aug, src/qemu.conf > Add 'hugetlbfs_mount' config parameter > * src/qemu_conf.c, src/qemu_conf.h: Check for -mem-path flag in QEMU, > and pass it when hugepages are requested. > Load hugetlbfs_mount config parameter, search for mount if not given. > * src/qemu_driver.c: Free hugetlbfs_mount/path parameter in driver shutdown. > Create directory for QEMU hugepage usage, chowning if required. > * docs/formatdomain.html.in: Document memoryBacking/hugepages elements > * docs/schemas/domain.rng: Add memoryBacking/hugepages elements to schema > * src/util.c, src/util.h, src/libvirt_private.syms: Add virFileFindMountPoint > helper API > * tests/qemuhelptest.c: Add -mem-path constants > * tests/qemuxml2argvtest.c, tests/qemuxml2xmltest.c: Add tests for hugepage > handling > * tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml, > tests/qemuxml2argvdata/qemuxml2argv-hugepages.args: Data files for > hugepage tests > --- > configure.in | 2 +- > docs/formatdomain.html | 8 +++- > docs/formatdomain.html.in | 8 +++ > docs/schemas/domain.rng | 9 ++++ > qemud/libvirtd_qemu.aug | 1 + > qemud/test_libvirtd_qemu.aug | 4 ++ > src/domain_conf.c | 10 ++++- > src/domain_conf.h | 1 + > src/libvirt_private.syms | 1 + > src/qemu.conf | 13 +++++ > src/qemu_conf.c | 49 ++++++++++++++++++++ > src/qemu_conf.h | 3 + > src/qemu_driver.c | 34 ++++++++++++++ > src/util.c | 37 ++++++++++++++- > src/util.h | 4 ++ > tests/qemuhelptest.c | 6 ++- > tests/qemuxml2argvdata/qemuxml2argv-hugepages.args | 1 + > tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml | 25 ++++++++++ > tests/qemuxml2argvtest.c | 7 ++- > tests/qemuxml2xmltest.c | 1 + > 20 files changed, 217 insertions(+), 7 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hugepages.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml I did a fetch on libvirt.git before reviewing and it appears there is some code motion relative to the version this patch was against. Although AFAICT nothing which appears to result in more than patch bounce. Looks good to me. ACK. -john -- john.cooper@xxxxxxxxxx -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list