On 04/16/2018 02:06 AM, Chris Venteicher wrote: > Implementation of libvirt functions to support the > QEMU query-cpu-model-baseline QMP command. > > This is part of resolution of: https://bugzilla.redhat.com/show_bug.cgi?id=1511999 > > Signed-off-by: Chris Venteicher <cventeic@xxxxxxxxxx> > > Chris Venteicher (3): > qemu_monitor_json: Populate CPUModelInfo struct from json > qemu_monitor_json: Build Json CPU Model Info > qemu_monitor: query-cpu-model-baseline QMP command > > src/qemu/qemu_monitor.c | 16 ++++ > src/qemu/qemu_monitor.h | 5 ++ > src/qemu/qemu_monitor_json.c | 179 +++++++++++++++++++++++++++++++++++++------ > src/qemu/qemu_monitor_json.h | 7 ++ > 4 files changed, 185 insertions(+), 22 deletions(-) > Hi Chris, I'm working on a neighboring item with implementing cpu-comparison. Since there are some similarities with both comparison and baseline, I'd like for us to work together on driving both features forward. Thus far, I've created the qemu_monitor_json interface, tied it into the qemu driver, and can issue virsh cpu-compare <file.xml> successfully. (Though it's no where near perfect yet ;) ) I've already noted some differences between our JSON interaces (namely, yours works with qemuMonitorCPUModelInfoPtrs, and mine works with virCPUDefPtrs). Ultimately, I think your patches are in good shape. Let's discuss further on my comparison patches posted here: https://www.redhat.com/archives/libvir-list/2018-April/msg01375.html I'm open to any suggestions / design ideas you have. -- Respectfully, - Collin Walling -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
