Re: [PATCH v2 67/73] qemu: Store API flags for async jobs in qemuDomainJobObj

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 11, 2018 at 04:41:57PM +0200, Jiri Denemark wrote:
When an async job is running, we sometimes need to know how it was
started to distinguish between several types of the job, e.g., post-copy
vs. normal migration. So far we added a specific bool item to
qemuDomainJobObj for such cases, which doesn't scale very well and
storing such bools in status XML would be painful so we didn't do it.

A better approach is to store the flags passed to the API which started
the async job, which can be easily stored in status XML.

Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
---
src/qemu/qemu_domain.c    | 10 ++++++++--
src/qemu/qemu_domain.h    |  4 +++-
src/qemu/qemu_driver.c    | 31 +++++++++++++++++++------------
src/qemu/qemu_migration.c | 20 +++++++++++++-------
src/qemu/qemu_process.c   |  5 +++--
src/qemu/qemu_process.h   |  3 ++-
6 files changed, 48 insertions(+), 25 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux