On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
> Implied by QEMU >= 1.2.0.
>
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
> src/qemu/qemu_capabilities.c | 1 -
> src/qemu/qemu_capabilities.h | 2 +-
> src/qemu/qemu_command.c | 3 +--
> src/qemu/qemu_hotplug.c | 9 +++------
> src/qemu/qemu_interface.c | 4 +---
> src/qemu/qemu_interface.h | 1 -
> tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 -
> tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 -
> 31 files changed, 6 insertions(+), 39 deletions(-)
Looks like we have zero test suite coverage for the vhost-net
feature. Neat.
[...]
> @@ -645,8 +644,7 @@ qemuInterfaceOpenVhostNet(virDomainDefPtr def,
> /* If qemu doesn't support vhost-net mode (including the -netdev command
> * option), don't try to open the device.
> */
> - if (!(virQEMUCapsGet(qemuCaps, QEMU_CAPS_VHOST_NET) &&
> - qemuDomainSupportsNicdev(def, net))) {
> + if (!(qemuDomainSupportsNicdev(def, net))) {
> if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_VHOST) {
> virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> "%s", _("vhost-net is not supported with "
The parentheses around the call to qemuDomainSupportsNicdev() are
unnecessary now, please get rid of them.
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
