On 04/10/2018 10:58 AM, Michal Privoznik wrote:
> Couple of reasons for that:
>
> a) there's no monitor command to change path where the pr-helper
> connects to, or
> b) there's no monitor command to introduce a new pr-helper for a
> disk that already exists.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> src/libvirt_private.syms | 1 +
> src/qemu/qemu_domain.c | 8 ++++++++
> src/util/virstoragefile.c | 18 ++++++++++++++++++
> src/util/virstoragefile.h | 2 ++
> 4 files changed, 29 insertions(+)
>
[...]
> diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> index 9917837513..b017024b2f 100644
> --- a/src/util/virstoragefile.c
> +++ b/src/util/virstoragefile.c
> @@ -2022,6 +2022,24 @@ virStoragePRDefFormat(virBufferPtr buf,
> }
>
>
> +bool
> +virStoragePRDefIsEqual(virStoragePRDefPtr a,
> + virStoragePRDefPtr b)
> +{
> + if (!a && !b)
> + return true;
> +
> + if (!a || !b)
> + return false;
> +
> + if (a->enabled != b->enabled ||
> + a->managed != b->managed ||
> + STRNEQ_NULLABLE(a->path, b->path))
> + return false;
> +
> + return true;
> +}
> +
two blank lines
[...]
Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>
John
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
