Re: [libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
> > > I reckon this snippet of code could usefully be put into the util.h file
> > > as virFileGenerateRandomkey(), or alternatively perhaps secret_conf.h, 
> > > as virSecretGenerateRandomKey(unsigned char *buf, size_t buflen);
> > This code, with its limitation to ASCII characters, is
> qcow/qemu-specific.
> 
> Ok, lets leave it in the QEMU driver file then
AFAICS the qemu and storage drivers can be built as modules, this would create a dependency.  I'll just split the code into a separate function for now.
    Mirek

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]