On Thu, Apr 12, 2018 at 01:47:06PM +0200, Ján Tomko wrote: > On Thu, Apr 12, 2018 at 12:35:21PM +0100, Daniel P. Berrangé wrote: > > On Thu, Mar 29, 2018 at 01:09:49AM +0200, Ján Tomko wrote: > > > Prefer Jansson, but allow fallback/choice of yajl. > > > > > > Support for yajl can hopefully be dropped after we ditch CentOS 6 > > > which has no Jansson. > > > > Seems like we can revisit this patch series given our discusions > > about supported platforms. > > > > Sadly, yes. > > I don't see Jansson in the list of SLES 12 packages: > https://www.suse.com/LinuxPackages/packageRouter.jsp?product=server&version=12&service_pack=&architecture=x86_64&package_name=index_all > > But json-c does seem to be everywhere. json-c header files pollute the global namespace with this: #undef FALSE #define FALSE ((json_bool)0) #undef TRUE #define TRUE ((json_bool)1) #define hexdigit(x) (((x) <= '9') ? (x) - '0' : ((x) & 7) + 9) #define error_ptr(error) ((void*)error) #define error_description(error) (json_tokener_errors[error]) #define is_error(ptr) (ptr == NULL) so I find json-c really unappealing to use. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
