Re: [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-04-12 at 11:54 +0200, Ján Tomko wrote:
> > I just realized that all of these should have a qemu: prefix in
> > the first line of the commit message. Before pushing, can you
> > please make sure they do?
> 
> I rarely use prefixes, they take up valuable space in the commit
> summary.
> 
> 'QEMU' is already contained in QEMU_CAPS if you're reading the single
> commit summary.
> 
> If you want to see changes just from qemu, you can filter by the
> src/qemu path
> 
> So what is the value they add?

They make the commit history look more consistent.

But feel free to disregard this comment if you feel stongly
otherwise, I really don't care that much at the end of the day.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux