On Wed, 2018-04-11 at 12:34 +0100, Daniel P. Berrangé wrote: > On Wed, Apr 11, 2018 at 12:29:11PM +0100, Radostin Stoyanov wrote: > > This patch set contains rebased version of Katerina's work from GSoC 2016 [1]. > > It allows integrates CRIU [2] with the libvirt-lxc to enable save/resore of containers. > > I vaguely recall that when Katerina first did that work, we hit some > limitations of CRIU at the time, that blocked us merging. Does anyone > recall what that was, and if & when it was addressed in CRIU ? What was missing in CRIU was the possibility to write the data into a stream rather than in files. From what I recall this work has been merged upstream in the mean time. -- Cedric > > > > [1] https://wiki.libvirt.org/page/Google_Summer_of_Code_2016/lxc_migration > > [2] https://criu.org > > > > Radostin Stoyanov (4): > > configure: Include support for CRIU > > lxc: Add save/restore helper functions > > lxc: Add restore mode for libvirt-lxc > > lxc: Add save/restore support > > > > configure.ac | 1 + > > m4/virt-criu.m4 | 27 +++++ > > po/POTFILES.in | 1 + > > src/lxc/Makefile.inc.am | 4 + > > src/lxc/lxc_container.c | 162 ++++++++++++++++++++++++++++-- > > src/lxc/lxc_container.h | 3 +- > > src/lxc/lxc_controller.c | 104 ++++++++++++++++++- > > src/lxc/lxc_criu.c | 253 +++++++++++++++++++++++++++++++++++++++++++++++ > > src/lxc/lxc_criu.h | 36 +++++++ > > src/lxc/lxc_driver.c | 238 +++++++++++++++++++++++++++++++++++++++++++- > > src/lxc/lxc_process.c | 23 ++++- > > src/lxc/lxc_process.h | 1 + > > 12 files changed, 836 insertions(+), 17 deletions(-) > > create mode 100644 m4/virt-criu.m4 > > create mode 100644 src/lxc/lxc_criu.c > > create mode 100644 src/lxc/lxc_criu.h > > > > -- > > 2.14.3 > > > > -- > > libvir-list mailing list > > libvir-list@xxxxxxxxxx > > https://www.redhat.com/mailman/listinfo/libvir-list > > Regards, > Daniel -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list