On Tue, Apr 10, 2018 at 08:58 AM +0200, Michal Privoznik <mprivozn@xxxxxxxxxx> wrote:
> The array of strings we are building is indeed array of const
> strings. We are not STRDUP()-ing them nor FREE()-ing them.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> src/qemu/qemu_domain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index f03aa03e8a..0486c5527d 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -11196,7 +11196,7 @@ qemuDomainNamespaceSetupDisk(virDomainObjPtr vm,
> virStorageSourcePtr src)
> {
> virStorageSourcePtr next;
> - char **paths = NULL;
> + const char **paths = NULL;
> size_t npaths = 0;
> int ret = -1;
>
> @@ -11214,7 +11214,7 @@ qemuDomainNamespaceSetupDisk(virDomainObjPtr vm,
> goto cleanup;
> }
>
> - if (qemuDomainNamespaceMknodPaths(vm, (const char **)paths, npaths) < 0)
> + if (qemuDomainNamespaceMknodPaths(vm, paths, npaths) < 0)
> return -1;
>
> ret = 0;
> --
> 2.16.1
>
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Reviewed-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx>
--
Beste Grüße / Kind regards
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
