On 04/09/2018 10:33 AM, Daniel P. Berrangé wrote: > On Mon, Apr 09, 2018 at 05:20:07PM +0200, Ján Tomko wrote: >> Implied by QEMU >= 1.2.0. >> >> +++ b/src/qemu/qemu_capabilities.h >> @@ -85,7 +85,7 @@ typedef enum { >> /* 25 */ >> X_QEMU_CAPS_BALLOON, /* -balloon available */ >> X_QEMU_CAPS_DEVICE, /* Is the -device arg available */ >> - QEMU_CAPS_SDL, /* Is the new -sdl arg available */ >> + X_QEMU_CAPS_SDL, /* Is the new -sdl arg available */ > > Hmm, even if -sdl is available, QEMU might have been built without SDL > support. I wonder if there is any way we can probe to see if SDL is > truely available.... I'm not sure if qemu's query-command-line-options tracks this yet (one of Markus' goal on cleaning up QemuOpts to be introspectible); there's also Marc-Andre's work towards making query-qmp-schema actually be compiled with appropriate #if conditionals, but that won't land before qemu 2.13. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list