Re: [PATCH 09/11] tests: Use pcie-to-pci-bridge for aarch64-traditional-pci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-04-03 at 19:15 -0400, John Ferlan wrote:
> On 03/28/2018 10:06 AM, Andrea Bolognani wrote:
> > Now that support for the pcie-to-pci-bridge controller has
> > been implemented, adding the QEMU_CAPS_DEVICE_PCIE_PCI_BRIDGE
> > capability to the existing test is enough to cause the guest
> > to use pcie-to-pci-bridge instead of dmi-to-pci-bridge.
> > 
> > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> > ---
> >  tests/qemuxml2argvdata/aarch64-traditional-pci.args  |  7 ++++---
> >  tests/qemuxml2argvtest.c                             |  1 +
> >  tests/qemuxml2xmloutdata/aarch64-traditional-pci.xml | 16 ++++++++--------
> >  tests/qemuxml2xmltest.c                              |  1 +
> >  4 files changed, 14 insertions(+), 11 deletions(-)
> 
> Surprised this isn't part of some earlier patch, but it's fine here too
> I suppose.

I could add the test case *after* introducing the capability: then
the test results would change automatically with the previous patch.
I don't have a strong preference either way.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux