On Thu, Mar 29, 2018 at 01:51:05PM +0200, Peter Krempa wrote:
This format is used by the storage driver and other hypervisors but qemu does not have nothion of the 'iso' format and libvirt does not translate
s/nothion/notion/
it to anything useful, so it would not work anyways. Users should use
'raw' instead.
Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
src/qemu/qemu_domain.c | 7 +++++++
tests/qemuxml2argvdata/disk-drive-fmt-iso.xml | 27 +++++++++++++++++++++++++++
tests/qemuxml2argvtest.c | 1 +
3 files changed, 35 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-drive-fmt-iso.xml
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 88b4653da5..e02da9e608 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4124,6 +4124,13 @@ qemuDomainValidateStorageSource(virStorageSourcePtr src)
return -1;
}
+ if (src->format == VIR_STORAGE_FILE_ISO) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+ _("storage format 'iso' is not directly suppored by qemu, "
s/suppored/supported/
+ "use 'raw' instead")); + return -1;
ACK Jano
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
