Re: [PATCH] docs: formatdomain: Clarify CPU feature policy option "require"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/26/2018 06:53 AM, Kashyap Chamarthy wrote:
> (Thanks: Jiri Denemark, for clarifying this on IRC.)

Lost context here!  That should have gone under the --- cause it'll look
awfully strange in git history.

Is there "more" or "extra" text you'd like to see added?  Or is the
commit message good enough?  I can add before pushing so you don't need
to spin another version...

> 
> Signed-off-by: Kashyap Chamarthy <kchamart@xxxxxxxxxx>
> ---
>  docs/formatdomain.html.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 6fd2189cd..2410c92af 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -1532,7 +1532,7 @@
>              of it being supported by host CPU.</dd>
>            <dt><code>require</code></dt>
>            <dd>Guest creation will fail unless the feature is supported by host
> -            CPU.</dd>
> +            CPU or the hypervisor is able to emulate it".</dd>
                                                          ^
I'll also remove the random "

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

(should be safe for freeze too, but I won't push until my commit message
question is answered).

>            <dt><code>optional</code></dt>
>            <dd>The feature will be supported by virtual CPU if and only if it
>              is supported by host CPU.</dd>
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux