On Thu, 2018-03-29 at 15:14 +0200, Pavel Hrdina wrote: > On Thu, Mar 29, 2018 at 01:07:57PM +0200, Katerina Koukiou wrote: > > Instead of having multiple signals regarding to domain events, > > like DomainStarted, DomainUndefined etc, we will have only one > > called Domain, and the specific event type will be specified in > > the signals arguments. > > > > The domain name argument in not needed in the signal since we can > > fetch it from path. > > > > The tests are adjusted to call correctly connect_to_signal method > > on the new signal. > > > > Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx> > > --- > > data/org.libvirt.Connect.xml | 54 +++----------------------------- > > ------------ > > src/events.c | 26 ++++++++++----------- > > test/test_connect.py | 10 ++++---- > > test/test_domain.py | 20 +++++++--------- > > 4 files changed, 27 insertions(+), 83 deletions(-) > > > > diff --git a/data/org.libvirt.Connect.xml > > b/data/org.libvirt.Connect.xml > > index f24dff4..6810422 100644 > > --- a/data/org.libvirt.Connect.xml > > +++ b/data/org.libvirt.Connect.xml > > @@ -44,59 +44,11 @@ > > <arg name="uuid" type="s" direction="in"/> > > <arg name="domain" type="o" direction="out"/> > > </method> > > - <signal name="DomainCrashed"> > > + <signal name="Domain"> > > I'm not sure about using "Domain" as the signal name, how about > "DomainEvent", "DomainChanded" or "DomainState"? DomainEvent sounds good. Changed. > > Pavel -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
