On Wed, Mar 28, 2018 at 7:52 PM, Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote:
You'll need to resend, and also add a Signed-off-by line so that we canOn Wed, Mar 28, 2018 at 07:49:09PM +0300, David Kiarie wrote:
> On Wed, Mar 28, 2018 at 7:46 PM, David Kiarie <davidkiarie4@xxxxxxxxx>
> wrote:
>
> >
> >
> > On Wed, Mar 28, 2018 at 7:43 PM, Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > wrote:
> >
> >> On Wed, Mar 28, 2018 at 07:33:11PM +0300, David Kiarie wrote:
> >> > On Wed, Mar 28, 2018 at 5:32 PM, Daniel P. Berrangé <
> >> berrange@xxxxxxxxxx>
> >> > wrote:
> >> >
> >> > > On Mon, Mar 26, 2018 at 10:29:06AM +0300, David Kiarie wrote:
> >> > > > I'd like to snip my name and email from these files
> >> > >
> >> > > Any particular reason why ?
> >> > >
> >> > >
> >> > Yes, I do have a particular reason why but it's not very relevant around
> >> > here.
> >>
> >> NB, patches require a Signed-off-by line to be commited, so can you
> >> resend with that.
> >>
> >
> > I'm just angry about some internet idiot who might use my name to track me
> > around.
> >
> >
> >>
> >> >
> >> > > > ---
> >> > > > src/xenconfig/xen_xl.c | 1 -
> >> > > > src/xenconfig/xen_xl.h | 1 -
> >> > > > 2 files changed, 2 deletions(-)
> >> > >
> >> > > It is also mentioned in test/xlconfigtest.c.
> >>
> >> And presumably you want to remove from this file too ?
> >>
> >
> > I'm just confused. Not so sure he's smart enough to figure that out.
> >
>
> Okay, shall I redo this patch or would you be kind enough to do it ?
commit it.
What ? You mean my patch didn't have a Signed-off-by line ?!
It's long since I did git.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list