[libvirt] [PATCH] virsh vol-key segfault fix

[Pritesh Kothari <Pritesh.Kothari@xxxxxxx>]

Hi,

There is a bug in virsh command vol-key, it segfaults cause the fourth option 
to vshCommandOptVolBy() is null instead of "pool" on virsh.c:5209.

The patch to fix this is attached.

Regards,
Pritesh

diff --git a/src/virsh.c b/src/virsh.c
index 2d0cf81..15e0cef 100644
--- a/src/virsh.c
+++ b/src/virsh.c
@@ -5206,7 +5206,7 @@ cmdVolKey(vshControl *ctl, const vshCmd *cmd)
     if (!vshConnectionUsability(ctl, ctl->conn, TRUE))
         return FALSE;
 
-    if (!(vol = vshCommandOptVolBy(ctl, cmd, "vol", NULL, NULL,
+    if (!(vol = vshCommandOptVolBy(ctl, cmd, "vol", "pool", NULL,
                                    VSH_BYUUID)))
         return FALSE;
 

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list