Re: [dbus PATCH 1/4] maint: remove AUTHORS from repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote:
> This is tracked by git itself.  Suggested during fedora package review.

AUTHORS is a file that autoconf/automake expects to exist in all
projects. Also the git history is not included with the tar.gz
dist, so IMHO the AUTHORS is appropriate to keep regardless.

> 
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  AUTHORS.in           | 13 -------------
>  Makefile.am          | 14 --------------
>  libvirt-dbus.spec.in |  2 +-
>  3 files changed, 1 insertion(+), 28 deletions(-)
>  delete mode 100644 AUTHORS.in
> 
> diff --git a/AUTHORS.in b/AUTHORS.in
> deleted file mode 100644
> index 988dd6a..0000000
> --- a/AUTHORS.in
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -       libvirt-dbus Authors
> -       ====================
> -
> -The primary maintainers of libvirt-dbus are:
> -
> -    Lars Karlitski <lars@xxxxxxxxxxxxx>
> -    Pavel Hrdina <phrdina@xxxxxxxxxx>
> -
> -Patches have been received from:
> -
> -#authorslist#
> -
> -   ... send patches to get your name added ...
> diff --git a/Makefile.am b/Makefile.am
> index a890ff1..0c792c1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -6,7 +6,6 @@ ACLOCAL_AMFLAGS = -I m4
>  EXTRA_DIST = \
>  	$(PACKAGE).spec \
>  	$(PACKAGE).spec.in \
> -	AUTHORS.in \
>  	HACKING.md \
>  	README.md \
>  	$(NULL)
> @@ -15,16 +14,3 @@ DISTCLEAN_FILES = $(PACKAGE).spec
>  
>  rpm: clean
>  	@(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz)
> -
> -dist-hook: gen-AUTHORS
> -
> -# Generate the AUTHORS file (with all entries since the switch to git)
> -# and insert it into the directory we're about to use to create a tarball.
> -.PHONY: gen-AUTHORS
> -gen-AUTHORS:
> -	$(AM_V_GEN)if test -d $(srcdir)/.git; then                      \
> -	  out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' | sort -u`" && \
> -	  perl -p -e "s/#authorslist#// and print '$$out'"            \
> -	    < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp &&        \
> -	  mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ;           \
> -	fi
> diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in
> index 1cf5922..3a04ad6 100644
> --- a/libvirt-dbus.spec.in
> +++ b/libvirt-dbus.spec.in
> @@ -52,7 +52,7 @@ exit 0
>  
>  %files
>  %defattr(-,root,root,-)
> -%doc README.md HACKING.md COPYING AUTHORS NEWS
> +%doc README.md HACKING.md COPYING NEWS
>  %{_sysconfdir}/polkit-1/rules.d/libvirt-dbus.rules
>  %{_bindir}/libvirt-dbus
>  %{_datadir}/dbus-1/services/org.libvirt.service
> -- 
> 2.14.3
> 
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux