On 03/26/2018 10:44 AM, Peter Krempa wrote: > On Mon, Mar 26, 2018 at 09:49:08 +0200, Peter Krempa wrote: >> On Mon, Mar 26, 2018 at 07:16:42 +0200, Michal Privoznik wrote: >>> Unless overridden, libdevmapper logs all messages to stderr. >>> Therefore if something goes wrong in storage_backend_mpath.c or >>> parthelper.c we don't honour user set logging targets. > > 'parthelper.c' does not use our logging code and also does not use any > libdevmapper.h functions. According to my experiment the header file > include can be dropped. > >>> >>> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >>> --- >>> src/util/virlog.c | 23 +++++++++++++++++++++++ >>> 1 file changed, 23 insertions(+) >> >> I think this should be done in the function which registers the mpath >> storage backend. For now it should work as is, but given that we are >> going to split the daemons this code will not really be necessary in >> other places. > > So looking at the new code you've added in this series, it still might > be desirable to move all the libdevmapper use into the storage driver > and keep it there, so users wanting to use multipath would need to > install the corresponding storage driver. > > Given that moving it there might be impractical, I'll suggest that you > move it to a separate util file and add virOnce infrastructure to set > the error helpers. > Okay, fair enough. I'll wait for review on the rest of the patches before I post v2. Thanks, Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
