Re: [dbus PATCH v2 0/6] Use API calls supporting flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 23, 2018 at 05:57:58PM +0100, Katerina Koukiou wrote:
> * Use API calls with flags parameter when possible
> * Since libvirt-dbus API doesn't follow strictly the naming
>   of libvirt API there should be documentation regarding which
>   libvirt API is used for each libvirt-dbus API.
>   This patch introduces documentation annotations in D-Bus Interface XML
>   files which will be used later to generate proper documentation.
> 
> Katerina Koukiou (6):
>   virtDBusDomainGetVcpus: Should be implemented as method and not as
>     property
>   virtDBusDomainShutdown: Use virDomainShutdownFlags instead of
>     virDomainShutdown
>   virtDBusDomainCreate: Use virDomainCreateWithFlags instead of
>     virDomainCreate
>   virtDBusDomainUndefine: Use virDomainUndefineFlags instead of
>     virDomainUndefine
>   virtDBusDomainDestroy: Use virDomainDestroyFlags instead of
>     virDomainDestroy
>   Use Documentation Annotations in D-Bus Interface XML

Thanks for the patches, I'll fix the issues before pushing.

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux