Re: [PATCH sandbox] Python 3 renamed string.lowercase to string.ascii_lowercase

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 23, 2018 at 04:44:51PM +0000, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>

ACK, but the commit message is misleading.

Python2 has ascii_lowercase as early as 2.2 and in Python3, lowercase
disappeared.

lowercase is the locale-dependent version, which seems to be identical
to ascii_lowercase for UTF-8 locales, but if you use a non-UTF one, fun
things happen:
locale.setlocale(locale.LC_ALL, 'sk_SK')
'sk_SK'
print string.lowercase
abcdefghijklmnopqrstuvwxyząłľśšşťźžżßŕáâăäĺćçčéęëěíîďđńňóôőöřůúűüýţ

Jano

---
libvirt-sandbox/image/cli.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt-sandbox/image/cli.py b/libvirt-sandbox/image/cli.py
index d2035de..605183c 100644
--- a/libvirt-sandbox/image/cli.py
+++ b/libvirt-sandbox/image/cli.py
@@ -81,7 +81,7 @@ def prepare(args):
                           connect=args.connect)

def random_domain_name(tmpl):
-    randomid = ''.join(random.choice(string.lowercase) for i in range(10))
+    randomid = ''.join(random.choice(string.ascii_lowercase) for i in range(10))
    return re.sub('[^a-z0-9-]', '_', tmpl.path[1:], re.I) + ":" + randomid

def run(args):
--
2.14.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux