On Fri, Mar 23, 2018 at 11:27:37AM -0400, Laine Stump wrote: > On 03/23/2018 07:46 AM, Daniel P. Berrangé wrote: > > In previous releases all these methods were a no-op if the network > > driver is disabled. These helper methods are called unconditionally for > > all types of network interface, so must be no-ops if missing. Other code > > will already generate an error if the network driver is disabled and a > > NIC with type=network is used. > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > Reviewed-by: Laine Stump <laine@xxxxxxxxx> > > I've been thinking about this the last few hours. The end-game of making > the network driver available separately is to have all of the > functionality for setting up network interfaces be in the network > driver, including creation of tap devices and attaching them to bridges, > adding iptables rules, setting QoS. Once this is done, it will no longer > be possible to build with --without-network and have a functionally > useful libvirtd. Either we will have to redefine what > "--without-network" means (so that it just applies to the "virtual > networks" part of the network driver), or remove that option. NB, I had only been anticipating using virtnetworkd for TAP device setup from the unprivileged libvirtd, no change to privileged libvirtd. Having said that though, is would be compelling to only have 1 codepath to care about. So if we do what you mention here, I think we would make sure that --without-network just disables the virtual network functionality. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
