Re: [PATCH] lxc: report error message raised by the failing function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 23, 2018 at 01:30:22PM +0100, Cedric Bosdonnat wrote:
> Hello Prafull,
> 
> On Thu, 2018-03-22 at 20:04 +0530, Prafull wrote:
> > The code that calls VIR_WARN after a function fails, doesn't
> > report the error message raised by the failing function.
> > Such error messages are now reported in lxc/lxc_driver.c
> > 
> > Signed-off-by: Prafullkumar T <talep158@xxxxxxxxx>
> 
> Sorry for asking a potentially dumb question, but I know nothing of the
> Indian culture. Is 'Prafullkumar T' your firstname and lastname? Just make
> sure your first and last names are used for signing off and committing.
> 
> For this, set the user.name in your git repo (or globally). You can also
> change the author of an existing commit with:
> 
>     git commit --amend --author 'fullname <email>'
> 
> Other than that, your commit looks fine to me. Note that you haven't used
> your full name as commit author. I'll wait for a v2 with updated names to push.

We already dealt with that on IRC - i'll push with the full name
shortly.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux