Re: [jenkins-ci PATCH 4/3] guests: Remove ad-hoc package installation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 21, 2018 at 04:17:48PM +0100, Andrea Bolognani wrote:
> On Wed, 2018-03-21 at 16:03 +0100, Pavel Hrdina wrote:
> > > -    # Prepare the base environment
> > > +    # Prepare environment. None of the actions performed here might
> > > +    # depend on packages being installed
> > >      - include: tasks/base.yml
> > >      - include: tasks/compat.yml
> > > -    - include: tasks/user.yml
> > >  
> > >      # Install base packages
> > >      - include: tasks/packages.yml
> > >        vars:
> > >          project: base
> > >  
> > > +    # Create users. This needs to happen after installing base packages
> > > +    - include: tasks/user.yml
> > > +
> > 
> > This would be solved by moving the package installation into the base
> > task.
> 
> Not really: the ordering requirement would still be present, just
> hidden inside base.yml. You would still need to make sure base.yml
> is included before user.yml.
> 
> I guess it's really up to preference, at the end of the day. As
> mentioned in the other message, I like the flat structure better :)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux