On 19/03/18 11:03, Daniel P. Berrangé wrote: > On Mon, Mar 19, 2018 at 10:36:28AM +0000, Daniel P. Berrangé wrote: >> On Sat, Mar 17, 2018 at 02:23:18PM +0000, Radostin Stoyanov wrote: >>> These patches improve the code style of python code >>> by applying some PEP8 recommendations and simplifying >>> some functions. >> How did you identify all the places that needed fixing ? I'm assuming you >> were running via some automated tool. If so this series ought to ensure >> that the tool is run as part of "make syntax-check", so that we don't >> reintroduce the problems later. I found the PEP8 places that needed fixing with pylint/pycodestyle and while fixing them I noticed some other places that could have been optimised. > Also, did you check whether the generated files are byte-for-byte identical > before & after applying this patch series, under both py2 & py3 ? > I checked the output of apibuild.py with: cd docs/ Then srcdir=. builddir=. /usr/bin/python2 ./apibuild.py; sha1sum *.xml | sha1sum and srcdir=. builddir=. /usr/bin/python3 ./apibuild.py; sha1sum *.xml | sha1sum Before and after applying the patches both commands returned the same hashsum (b068fa56c132fca35ba24302e0a394aa9f03be97) . > Regards, > Daniel Radostin -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
