On Sun, Aug 16, 2009 at 10:47:58PM +0200, Miloslav Trmač wrote:
> Changes since the second submission:
> - Update for the changed public API
> - s/secret_id/uuid/g
> - use "unsigned char *" for secret value
> ---
> src/datatypes.h | 1 +
> src/remote_internal.c | 323 +++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 324 insertions(+), 0 deletions(-)
[...]
> +static virDrvOpenStatus
> +remoteSecretOpen (virConnectPtr conn,
> + virConnectAuthPtr auth,
> + int flags)
> +{
> + if (inside_daemon)
> + return VIR_DRV_OPEN_DECLINED;
> +
> + if (conn &&
> + conn->driver &&
> + STREQ (conn->driver->name, "remote")) {
> + struct private_data *priv;
> +
> + /* If we're here, the remote driver is already
> + * in use due to a) a QEMU uri, or b) a remote
> + * URI. So we can re-use existing connection
> + */
Hum, is that comment right ? We are certainly using a remote URI in
any case there, isn't it ?
The driver looks fine, everything is synchronous but none of those
operations should be blocking in any way, ACK
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list