On 03/16/2018 03:46 PM, Jim Fehlig wrote: > libxlDomainMigrationPrepare adds the incoming domain def to the list > of domains via virDomainObjListAdd, but never adds its own ref to the > returned virDomainObj as other callers of virDomainObjListAdd do. > libxlDomainMigrationPrepareTunnel3 suffers the same discrepancy. > > Change both to add a ref to the virDomainObj after a successful > virDomainObjListAdd, similar to other callers. This ensures a consistent > pattern throughout the drivers and allows using the virDomainObjEndAPI > function for cleanup. > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > --- > > V2 of > > https://www.redhat.com/archives/libvir-list/2018-March/msg00674.html > > Changes in V2: > Add ref after call to virDomainObjListAdd so that EndAPI can be used > in the usual pattern. > > src/libxl/libxl_migration.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
