Re: [PATCH 17/20] remote: Add the information which program has to be used to daemonClientEventCallback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 03/08/2018 07:20 AM, Marc Hartmayer wrote:
> As a result, you can later determine at the callback which program has
> to be used. This makes it easier to refactor the code in the future
> and is less prone to error.
> 
> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx>
> ---
>  src/remote/remote_daemon_dispatch.c | 108 ++++++++++++++++++++----------------
>  1 file changed, 59 insertions(+), 49 deletions(-)
> 

Well if the previous patch made me nervous, this one has me shaking even
more!  Still my look through didn't find issues. Certainly an area that
I hope danpb may also take a loot.  I can ping him when I'm done - for
at least the remote/libvirtd stuff.

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux