Re: [PATCH v3 05/12] qemu: Store pr runtime data in status XML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 14, 2018 at 17:05:34 +0100, Michal Privoznik wrote:
> Now that we generate pr-manager alias and socket path store them
> in status XML so that they are preserved across daemon restarts.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/qemu/qemu_domain.c | 108 +++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 86 insertions(+), 22 deletions(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index c17e40dc8..d673ddbb2 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -1961,28 +1961,6 @@ qemuDomainObjPrivateFree(void *data)
>  }
>  
>  
> -static int
> -qemuStorageSourcePrivateDataParse(xmlXPathContextPtr ctxt,
> -                                  virStorageSourcePtr src)
> -{
> -    if (virStorageSourcePrivateDataParseRelPath(ctxt, src) < 0)
> -        return -1;
> -
> -    return 0;
> -}
> -
> -
> -static int
> -qemuStorageSourcePrivateDataFormat(virStorageSourcePtr src,
> -                                   virBufferPtr buf)
> -{
> -    if (virStorageSourcePrivateDataFormatRelPath(src, buf) < 0)
> -        return -1;
> -
> -    return 0;
> -}

Please don't move these out of here. I've specifically placed them here
since I'll need them way earlier than your patch puts them.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux