On Thu, Mar 15, 2018 at 11:07:36AM +0100, Andrea Bolognani wrote:
> On Thu, 2018-03-15 at 09:00 +0000, Daniel P. Berrangé wrote:
> > On Wed, Mar 14, 2018 at 05:31:39PM +0100, Andrea Bolognani wrote:
> > > As of 2499d1a09508 we don't link against libpolkit or look for
> > > the pkcheck command anymore, so these package relationships are
> > > no longer necessary and can be safely dropped.
> >
> > We still require polkit to be installed - the "polkit" RPM is what
> > provides the DBus service we talk to.
>
> That makes sense.
>
> So the Requires: need to stay; the BuildRequires: can be dropped
> though, right? Or at the very least we should be able to remove
> any reference to polkit-devel and only {,Build}Requires: polkit,
> as we're definitely no longer linking against any library.
Yeah the -devel is not needed, since m4/virt-polkit.m4 only looks at the
--enable-polkit and --enable-dbus args now
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
