On Mon, Aug 17, 2009 at 06:12:55PM +0100, Daniel P. Berrange wrote:
[...]
> + if (disk->serial)
> + virBufferVSprintf(&opt, ",serial=%s", disk->serial);
Sounds fine, just that if the content is free form maybe one need
to quote that argument
",serial='%s'"
to avoid potential problems. Also wondering what happens if qemu/kvm
doesn't support the option, maybe this should be part of the detected
features as Mark raised,
Good idea, ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list