On Wed, Mar 14, 2018 at 12:25:14 +0100, Jiri Denemark wrote:
> Having to repeat "./job[1]/" XPath prefix for every single element or
> attribute we want to parse is suboptimal. And even more so once we
> further extract code from qemuDomainObjPrivateXMLParseJob into separate
> functions.
>
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---
> src/qemu/qemu_domain.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index a08a1825e9..570ad4ea8f 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -2332,12 +2332,18 @@ qemuDomainObjPrivateXMLParseJob(virDomainObjPtr vm,
> xmlXPathContextPtr ctxt)
> {
> xmlNodePtr *nodes = NULL;
> + xmlNodePtr node = ctxt->node;
Rename this to saveNode. 'node' is usually used for a working pointer in
our parser code.
ACK
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
