On Tue, Mar 13, 2018 at 06:36:32PM +0100, Peter Krempa wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1553085 This breaks hotplug so that we can see whether the file was left dangling.
NACK, this breaks hotplug.
Reproduce by: virsh create dom.xml virsh attach-device memplug mem.xml ls /var/lib/libvirt/qemu/ram/libvirt/qemu/*-memplug After the failed hotplug, qemu should leave behind the file called 'dimm0' in the above path. The original bugreport was caused by failing in the 'device-add' phase. --- dom.xml | 110 ++++++++++++++++++++++++++++++++++++++++++++++++ mem.xml | 6 +++ src/qemu/qemu_hotplug.c | 3 ++ 3 files changed, 119 insertions(+) create mode 100644 dom.xml create mode 100644 mem.xml
Also, 'make syntax-check' does not pass: dom.xml maint.mk: empty line(s) or no newline at EOF make: *** [maint.mk:930: sc_prohibit_empty_lines_at_EOF] Error 1 make: *** Waiting for unfinished jobs.... Jan
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
