Re: [PATCH 01/20] driver: Add typedef for the anonymous enum used for driver features

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 03/08/2018 07:20 AM, Marc Hartmayer wrote:
> Add typedef for the anonymous enum used for the driver features. This
> allows the usage of the type in a switch statement and taking
> advantage of the compilers feature to detect uncovered cases.
> 
> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx>
> ---
>  src/esx/esx_driver.c                | 18 ++++++++++++++++--
>  src/libvirt_internal.h              |  4 ++--
>  src/libxl/libxl_driver.c            | 13 ++++++++++++-
>  src/lxc/lxc_driver.c                | 24 +++++++++++++++++++-----
>  src/openvz/openvz_driver.c          | 15 ++++++++++++++-
>  src/qemu/qemu_driver.c              |  8 +++++++-
>  src/remote/remote_daemon_dispatch.c | 19 ++++++++++++++++---
>  src/vz/vz_driver.c                  | 15 ++++++++++++++-
>  src/xen/xen_driver.c                | 15 ++++++++++++++-
>  9 files changed, 114 insertions(+), 17 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

(I forgot that I'd turned off deadcode detection in coverity; otherwise,
it surely would have complained in remoteDispatchConnectSupportsFeature
that it's not possible to get to the case since the code already checked
for VIR_DRV_FEATURE_PROGRAM_KEEPALIVE

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux