On Mon, Aug 17, 2009 at 03:10:19PM +0100, Mark McLoughlin wrote: > Newer versions of QEMU accept 'pci_add auto', but older versions require > 'pci_add pci_addr=auto' Ah yes, storage already does that too > > * src/qemu_driver.c: use pci_addr= in qemudDomainAttachHostPciDevice() > for older versions of QEMU > --- > src/qemu_driver.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index 048e1c0..a9da387 100644 > --- a/src/qemu_driver.c > +++ b/src/qemu_driver.c > @@ -5333,7 +5333,7 @@ static int qemudDomainAttachHostPciDevice(virConnectPtr conn, > > pciFreeDevice(conn, pci); > > - if (virAsprintf(&cmd, "pci_add auto host host=%.2x:%.2x.%.1x", > + if (virAsprintf(&cmd, "pci_add pci_addr=auto host host=%.2x:%.2x.%.1x", > hostdev->source.subsys.u.pci.bus, > hostdev->source.subsys.u.pci.slot, > hostdev->source.subsys.u.pci.function) < 0) { Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list