Re: [PATCH] keycodemapdb: Update submodule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-03-12 at 14:58 +0000, Daniel P. Berrangé wrote:
> On Mon, Mar 12, 2018 at 03:53:09PM +0100, Andrea Bolognani wrote:
> > On Mon, 2018-03-12 at 14:46 +0000, Daniel P. Berrangé wrote:
> > > > The build system doesn't get refreshed automatically after this
> > > > change, so it's still trying to generate virkeycodetable_rfb.h
> > > > and failing because the current version of keymap-gen doesn't know
> > > > about it.
> > > 
> > > Perhaps it would be better if I just made 'keymap-gen' continue to
> > > accept 'rfb' as a deprecated alias for 'qnum'
> > 
> > That would probably be nice regardless, but it wouldn't really help
> > here - unless we decided to stick with the old name in libvirt too.
> > Are you advocating for doing just that?
> 
> No, just take your patch as is. Just fix keymap-gen, so we make the
> (harmless) error message disappear for people with existing checkouts
> that have built the old filename.

But that still wouldn't work seamlessly, would it? The existing
build system would try to generate virkeycodetable_rfb.h, and
succeed, but the code won't compile because it's looking for
virkeycodetable_qnum.h and related symbols now.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux