On 03/06/2018 12:58 PM, Daniel P. Berrangé wrote: > Currently virNetServerClientDispatchFunc implementations are only > responsible for free'ing the "msg" parameter upon success. Simplify the > calling convention by making it their unconditional responsibility to > free the "msg", and close the client if desired. > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > --- > src/rpc/virnetserver.c | 24 +++++++++++++----------- > src/rpc/virnetserverclient.c | 6 +++--- > src/rpc/virnetserverclient.h | 9 ++++++--- > 3 files changed, 22 insertions(+), 17 deletions(-) > Chasing all the error paths for @msg to be freed is mind boggling ;-) Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list