On Wed, Mar 07, 2018 at 12:09:15PM +0100, Peter Krempa wrote: > On Wed, Mar 07, 2018 at 10:15:35 +0000, Daniel Berrange wrote: > > On Wed, Mar 07, 2018 at 10:29:29AM +0100, Ján Tomko wrote: > > > The build WITH_POLKIT0 and -Wunused-label was broken for almost two > > > years. > > > > Last time we discussed this, SUSE folks said they still had polkit0 on > > an actively supported distro. I'd like confirmation they don't still > > need it before removing, so copying Jim. > > Probably not very actively used though since nobody complained that it > was broken for so long. Well downstreams don't run with -Werror usually, so fact that -Wunused-label generated a warning doesn't mean it was broken for downstreams. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list