Re: [PATCH 1/6] qemu: add capability detection for query-cpus-fast

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/02/2018 12:44 PM, Peter Krempa wrote:
On Fri, Mar 02, 2018 at 10:29:06 +0100, Viktor Mihajlovski wrote:
Detect whether QEMU supports the QMP query-cpus-fast API
and set QEMU_CAPS_QUERY_CPUS_FAST in this case.

Signed-off-by: Viktor Mihajlovski <mihajlov@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx>
---
  src/qemu/qemu_capabilities.c | 4 +++-
  src/qemu/qemu_capabilities.h | 1 +
  2 files changed, 4 insertions(+), 1 deletion(-)

ACK, although you should add a qemucapabilitiestest case for the new
qemu supporting this command first probably.
Shouldn't this test come along automatically when the QEMU 2.12 replies/xml files containing the new qmp method is introduced? Or are you suggesting to create new QEMU 2.11_patched replies/xml files to test this?




--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux