On Fri, Mar 02, 2018 at 11:24:03AM +0100, Andrea Bolognani wrote: > On Fri, 2018-03-02 at 08:08 +0100, Martin Kletzander wrote: > > On Thu, Mar 01, 2018 at 04:52:09PM +0000, Daniel P. Berrangé wrote: > > > You show that we we missing CI coverage for python3 though, so we > > > should address that. We could make our Fedora Jenkins CI builds use py3, > > > along with one of our Travis scenarios, so we get a mix of py2&py3 > > > coverage in both Jenkins & Travis. > > > > Do we? I think the builds were switched so that we can run unit tests on > > virt-manager so now we have CI coverage for py2 as well as py3. > > We use both Python 2 and 3, but only for project that are themselves > implemented in Python (libvirt-python and virt-manager); what I > think Dan is referring to is that we only ever use Python 2 to call > keycodemapdb's own tools, so there's no Python 3 coverage for that. Yeah exactly - some bits of libvirt build process use python scripts and so we should test that under both. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
