We've recently discovered two separate bugs that caused libvirt's "DHCP Snooping" feature to not work: https://bugzilla.redhat.com/show_bug.cgi?id=1529338 - libvirt regression https://bugzilla.redhat.com/show_bug.cgi?id=1547237 - libpcap regression Since we didn't have any test suite covering that code, we had the embarrassment of learning of it from someone else's QE (RHV/oVirt QE at Red Hat). This series adds the necessary stuff to the test domain config of libvirt-tck's "no-ip-spoofing" test to exercise the DHCPSnoop thread. (There may be a much better way of dealing with a hash-inside-a-hash; I am an imbecile at perl, and arrived at this code by trial, error, and google searches). Laine Stump (4): nwfilter tests: auto-add test appliance ssh key to known_hosts on host new NetworkHelper function get_network_ip() set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test nwfilter tests: remove all hardcoded references to 192.168.122 network lib/Sys/Virt/TCK.pm | 11 ++++++++--- lib/Sys/Virt/TCK/DomainBuilder.pm | 8 +++++++- lib/Sys/Virt/TCK/NetworkHelpers.pm | 22 ++++++++++++++++++++++ scripts/nwfilter/210-no-mac-spoofing.t | 12 ++++++++---- scripts/nwfilter/220-no-ip-spoofing.t | 26 +++++++++++++++++++++----- scripts/nwfilter/230-no-mac-broadcast.t | 11 ++++++++--- scripts/nwfilter/240-no-arp-spoofing.t | 22 ++++++++++++++++------ 7 files changed, 90 insertions(+), 22 deletions(-) -- 2.14.3 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
